yihua commented on code in PR #9136:
URL: https://github.com/apache/hudi/pull/9136#discussion_r1267265487
##########
pom.xml:
##########
@@ -2614,6 +2614,18 @@
</activation>
</profile>
+ <profile>
+ <id>java17</id>
+ <properties>
+ <argLine>-Xmx2g --add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.lang.invoke=ALL-UNNAMED
--add-opens=java.base/java.lang.reflect=ALL-UNNAMED
--add-opens=java.base/java.io=ALL-UNNAMED
--add-opens=java.base/java.net=ALL-UNNAMED
--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED
--add-opens=java.base/sun.nio.cs=ALL-UNNAMED
--add-opens=java.base/sun.security.action=ALL-UNNAMED
--add-opens=java.base/sun.util.calendar=ALL-UNNAMED
--add-opens=java.security.jgss/sun.security.krb5=ALL-UNNAMED
-Djol.magicFieldOffset=true</argLine>
Review Comment:
Are these args needed for running production jobs on Java 17?
##########
pom.xml:
##########
@@ -156,7 +156,7 @@
<flink.clients.artifactId>flink-clients</flink.clients.artifactId>
<flink.connector.kafka.artifactId>flink-connector-kafka</flink.connector.kafka.artifactId>
<flink.hadoop.compatibility.artifactId>flink-hadoop-compatibility_2.12</flink.hadoop.compatibility.artifactId>
- <rocksdbjni.version>5.17.2</rocksdbjni.version>
+ <rocksdbjni.version>7.5.3</rocksdbjni.version>
Review Comment:
does RocksDB `5.17.2` not work? Dependency version upgrade has larger
impact.
##########
packaging/bundle-validation/docker_test_java17.sh:
##########
@@ -0,0 +1,170 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+#################################################################################################
+# NOTE: this script runs inside hudi-ci-bundle-validation container
+# $WORKDIR/jars/ is to mount to a host directory where bundle jars are placed
+# $WORKDIR/data/ is to mount to a host directory where test data are placed
with structures like
+# - <dataset name>/schema.avsc
+# - <dataset name>/data/<data files>
+#################################################################################################
+
Review Comment:
Could we consolidate the test logic of this into `validate.sh` and reuse
existing validate-bundle job?
##########
style/checkstyle.xml:
##########
@@ -269,7 +269,7 @@
<property name="regexp" value="true"/>
<property name="illegalPkgs" value="org\.apache\.commons,
com\.google\.common, org\.apache\.log4j"/>
<property name="illegalClasses"
- value="^java\.util\.Optional,
^org\.junit\.(?!jupiter|platform|contrib|Rule|runner)(.*)"/>
+ value="^java\.util\.Optional,
^org\.junit\.(?!jupiter|platform|contrib|Rule|runner|Assume)(.*)"/>
Review Comment:
Let's use the juniper version instead of changing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
