zhuanshenbsj1 commented on PR #9038:
URL: https://github.com/apache/hudi/pull/9038#issuecomment-1643566421

   > Description and context please...
   > 
   > # Illustration of issue before fix
   > Incremental has a sliding window that bounds it's cleaning partition as 
shown below. If there is an async table service action as shown in the 
illustration below, partitions might be skipped if it falls behind the cleaning 
window.
   > 
   > 
![image](https://user-images.githubusercontent.com/6312314/254827857-11e4900b-1b62-4b91-a427-cf2c13c2d41d.png)
   > 
   > Note: The illustration might not be the entirely correct in the 
determination of earliest commit to retain, but it does give a general 
illustration of the sliding window.
   > 
   > # Fix
   > In #7568, clean will be blocked by any pending action. As such, by 
factoring COMPACTION actions into the active timeline, the sliding window of 
incremental range will be bounded correctly to not ahead of any pending writes 
made via compaction.
   > 
   > 
![image](https://user-images.githubusercontent.com/6312314/254828626-bb8b0450-b2c6-40de-b52e-f3c60aa9fcac.png)
   
   
   
   > Description and context please...
   > 
   > # Illustration of issue before fix
   > Incremental has a sliding window that bounds it's cleaning partition as 
shown below. If there is an async table service action as shown in the 
illustration below, partitions might be skipped if it falls behind the cleaning 
window.
   > 
   > 
![image](https://user-images.githubusercontent.com/6312314/254827857-11e4900b-1b62-4b91-a427-cf2c13c2d41d.png)
   > 
   > Note: The illustration might not be the entirely correct in the 
determination of earliest commit to retain, but it does give a general 
illustration of the sliding window.
   > 
   > # Fix
   > In #7568, clean will be blocked by any pending action. As such, by 
factoring COMPACTION actions into the active timeline, the sliding window of 
incremental range will be bounded correctly to not ahead of any pending writes 
made via compaction.
   > 
   > 
![image](https://user-images.githubusercontent.com/6312314/254828626-bb8b0450-b2c6-40de-b52e-f3c60aa9fcac.png)
   
   Thanks for the description of the scene~~  Added to current pr change-logs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to