parisni opened a new pull request, #9245:
URL: https://github.com/apache/hudi/pull/9245

   ### Change Logs
   
   This makes the parquet bloom filter work correctly. After trying out the 
#8716 the bloom where not being created
   
   1. the reflexion usage was incorrect and this was silently doing nothing
   1. The reason is the test where not verifying correctly the bloom where 
created. A side effect of parquet stats where used in place of bloom in newer 
versions of parquet
   
   This PR :
   1. fixes the impl
   1. fixes the test
   
   Double check with parquet-cli after the patch confirmed the bloom exist. We 
cannot yet use such checks since only recent version of parquet can verify the 
bloom exist
   
   ### Impact
   
   _Describe any public API or user-facing feature change or any performance 
impact._
   
   ### Risk level (write none, low medium or high below)
   
   _If medium or high, explain what verification was done to mitigate the 
risks._
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, 
config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the 
default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. 
Please create a Jira ticket, attach the
     ticket number here and follow the 
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to 
make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to