codope commented on code in PR #9078:
URL: https://github.com/apache/hudi/pull/9078#discussion_r1270182007
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -1395,19 +1403,26 @@ public void
testAsyncClusteringServiceWithConflicts(HoodieRecordType recordType)
}
@ParameterizedTest
- @EnumSource(value = HoodieRecordType.class, names = {"AVRO", "SPARK"})
+ @EnumSource(value = HoodieRecordType.class, names = {"AVRO","SPARK"})
public void testAsyncClusteringServiceWithCompaction(HoodieRecordType
recordType) throws Exception {
- String tableBasePath = basePath + "/asyncClusteringCompaction";
+ String tableBasePath = basePath + "/asyncClusteringCompaction" +
RANDOM.nextInt(1000);
// Keep it higher than batch-size to test continuous mode
int totalRecords = 2000;
- // Initial bulk insert
- HoodieDeltaStreamer.Config cfg = TestHelpers.makeConfig(tableBasePath,
WriteOperationType.INSERT);
+ // user upsert as operation type.
Review Comment:
Can we commit this suggestion as well?
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/deltastreamer/TestHoodieDeltaStreamer.java:
##########
@@ -1395,19 +1403,26 @@ public void
testAsyncClusteringServiceWithConflicts(HoodieRecordType recordType)
}
@ParameterizedTest
- @EnumSource(value = HoodieRecordType.class, names = {"AVRO", "SPARK"})
+ @EnumSource(value = HoodieRecordType.class, names = {"AVRO","SPARK"})
public void testAsyncClusteringServiceWithCompaction(HoodieRecordType
recordType) throws Exception {
- String tableBasePath = basePath + "/asyncClusteringCompaction";
+ String tableBasePath = basePath + "/asyncClusteringCompaction" +
RANDOM.nextInt(1000);
// Keep it higher than batch-size to test continuous mode
int totalRecords = 2000;
- // Initial bulk insert
- HoodieDeltaStreamer.Config cfg = TestHelpers.makeConfig(tableBasePath,
WriteOperationType.INSERT);
+ // user upsert as operation type.
+ HoodieDeltaStreamer.Config cfg = TestHelpers.makeConfig(tableBasePath,
WriteOperationType.UPSERT);
Review Comment:
yeah i think we need to curate carefully such a scenario.
SparkAllowUpdaterStrategy does not really resolve the write-write conflict. It
will simply rollback clustering if `ROLLBACK_PENDING_CLUSTERING_ON_CONFLICT` is
configured as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
