nsivabalan commented on code in PR #9246:
URL: https://github.com/apache/hudi/pull/9246#discussion_r1270221495
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -277,7 +278,7 @@ public HoodieTimeline getCommitsTimeline() {
* Get all instants (commits, delta commits, replace, compaction) that
produce new data or merge file, in the active timeline.
*/
public HoodieTimeline getCommitsAndCompactionTimeline() {
- return getTimelineOfActions(CollectionUtils.createSet(COMMIT_ACTION,
DELTA_COMMIT_ACTION, REPLACE_COMMIT_ACTION, COMPACTION_ACTION));
+ return getTimelineOfActions(CollectionUtils.createSet(COMMIT_ACTION,
DELTA_COMMIT_ACTION, REPLACE_COMMIT_ACTION, COMPACTION_ACTION,
LOG_COMPACTION_ACTION));
Review Comment:
we should not fix this method. we should probably introduce
getCompletedCommitsCompactionLogCompactionTimeline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
