Zouxxyy commented on code in PR #9247:
URL: https://github.com/apache/hudi/pull/9247#discussion_r1270231679
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/utils/TestFlinkWriteClients.java:
##########
@@ -55,7 +57,19 @@ void testAutoSetupLockProvider() throws Exception {
conf.setBoolean(FlinkOptions.METADATA_ENABLED, true);
StreamerUtil.initTableIfNotExists(conf);
HoodieWriteConfig writeConfig =
FlinkWriteClients.getHoodieClientConfig(conf, false, false);
- assertThat(writeConfig.getLockProviderClass(),
is(FileSystemBasedLockProvider.class.getName()));
+ Assertions.assertTrue(writeConfig.isLockRequired());
+ assertThat(writeConfig.getLockProviderClass(),
is(InProcessLockProvider.class.getName()));
+ assertThat(writeConfig.getWriteConcurrencyMode(),
is(WriteConcurrencyMode.SINGLE_WRITER));
+ }
+
+ @Test
+ void testAutoSetupLockProviderWithoutTableService() throws Exception {
+ conf.setBoolean(FlinkOptions.METADATA_ENABLED, true);
+ conf.setBoolean("hoodie.table.services.enabled", false);
+ StreamerUtil.initTableIfNotExists(conf);
Review Comment:
Ok, so hudi table based on object storage can't enable metadata table
directly, because most of them can not support atomic creation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
