Zouxxyy commented on code in PR #9233:
URL: https://github.com/apache/hudi/pull/9233#discussion_r1271265156


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/IngestionPrimaryWriterBasedConflictResolutionStrategy.java:
##########


Review Comment:
   > @Zouxxyy I am yet to review the patch fully. Just curious, why removing 
this strategy? Is it taken care of in the new conflict resolver based on state 
transition time?
   
   Two reasons:
   1. If we want to use bucket index, ingestion primary, and don't want to use 
state transition time (because it is not stable yet), how to choose the 
strategy, should we write another one?
   2. I hope that the current strategy can automatically identify the bucket 
index and ingestion primary, which is better for users. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to