codope commented on code in PR #9292: URL: https://github.com/apache/hudi/pull/9292#discussion_r1275203971
########## hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java: ########## @@ -418,6 +417,8 @@ private void checkForSpuriousDeletes(HoodieMetadataPayload metadataPayload, Stri protected abstract Map<String, HoodieRecord<HoodieMetadataPayload>> getRecordsByKeys(List<String> keys, String partitionName); + protected abstract Map<String, List<HoodieRecord<HoodieMetadataPayload>>> getAllRecordsByKeys(List<String> keys, String partitionName); Review Comment: @nsivabalan I added a separate method (yet to fully implement) for separation as we will have duplicates only in case of RLI for now. But, should we chnage the return type existing `getRecordsByKeys`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
