danny0405 commented on code in PR #9230:
URL: https://github.com/apache/hudi/pull/9230#discussion_r1275787898
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/source/TestExpressionEvaluators.java:
##########
@@ -116,11 +124,12 @@ void testEqualTo() {
assertFalse(equalTo.eval(stats1), "It is not possible to test for NULL
values with '=' operator");
}
- @Test
- void testNotEqualTo() {
+ @ParameterizedTest
+ @MethodSource("twelveObjects")
+ void testNotEqualTo(Object twelve) {
Review Comment:
Can we write a separate test for all the data types instead of modifying
existing test. We just need to trigger the comparison of different data types.
For each of the data type, test the comprison of it to all the other data types.
Just a simple `Great Than(GT)` comparision should be enough ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
