danny0405 commented on code in PR #9317:
URL: https://github.com/apache/hudi/pull/9317#discussion_r1278971305


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/command/CreateHoodieTableCommand.scala:
##########
@@ -84,11 +84,7 @@ case class CreateHoodieTableCommand(table: CatalogTable, 
ignoreIfExists: Boolean
       CreateHoodieTableCommand.createTableInCatalog(sparkSession, 
hoodieCatalogTable, ignoreIfExists, queryAsProp)
     } catch {
       case NonFatal(e) =>
-        logWarning(s"Failed to create catalog table in metastore: ${e}")
-        val sw = new StringWriter
-        val pw = new PrintWriter(sw)
-        e.printStackTrace(pw)
-        logWarning(sw.toString)
+        logWarning(s"Failed to create catalog table in metastore: ", e)

Review Comment:
   The original code looks weird?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to