codope commented on code in PR #9324:
URL: https://github.com/apache/hudi/pull/9324#discussion_r1280185595
##########
pom.xml:
##########
@@ -2479,10 +2465,7 @@
<fasterxml.version>${fasterxml.spark3.version}</fasterxml.version>
<fasterxml.jackson.databind.version>${fasterxml.spark3.version}</fasterxml.jackson.databind.version>
<fasterxml.jackson.module.scala.version>${fasterxml.spark3.version}</fasterxml.jackson.module.scala.version>
- <fasterxml.jackson.dataformat.yaml.version>${fasterxml.spark3.version}
Review Comment:
Why is dataformat.yaml being removed?
##########
pom.xml:
##########
@@ -98,8 +98,6 @@
<fasterxml.jackson.databind.version>${fasterxml.spark3.version}</fasterxml.jackson.databind.version>
<fasterxml.jackson.module.scala.version>${fasterxml.spark3.version}</fasterxml.jackson.module.scala.version>
<fasterxml.jackson.dataformat.yaml.version>${fasterxml.spark3.version}</fasterxml.jackson.dataformat.yaml.version>
- <!-- NOTE: By default we're not including JSR310 module for Jackson since
Spark >= 3.x is bundling it anyway -->
- <fasterxml.jackson.datatype.jsr310.module/>
Review Comment:
why are removing it from main pom? By removing, this module will be included
which does not seem to be the intended behavior as per the comment.
##########
packaging/hudi-integ-test-bundle/pom.xml:
##########
@@ -319,12 +319,19 @@
<dependency>
<groupId>com.fasterxml.jackson.module</groupId>
<artifactId>jackson-module-scala_${scala.binary.version}</artifactId>
+ <version>${fasterxml.jackson.module.scala.version}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-yaml</artifactId>
- <version>2.7.4</version>
+ <version>${fasterxml.spark3.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>com.fasterxml.jackson.datatype</groupId>
+ <artifactId>jackson-datatype-jsr310</artifactId>
+ <version>${fasterxml.spark3.version}</version>
Review Comment:
Do we need to include the `version` tag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
