vinishjail97 commented on code in PR #9335:
URL: https://github.com/apache/hudi/pull/9335#discussion_r1280993432
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieClientOnCopyOnWriteStorage.java:
##########
@@ -404,6 +406,38 @@ public void testPreCommitValidationWithMultipleInflights()
throws Exception {
assertTrue(testTable.commitExists(instant2));
}
+ @Test
+ public void testInertsWithEmptyCommitsHavingWriterSchemaAsNull() throws
Exception {
+ // Set autoCommit false
+ HoodieWriteConfig.Builder cfgBuilder =
getConfigBuilder().withAutoCommit(false);
+ addConfigsForPopulateMetaFields(cfgBuilder, true);
+ SparkRDDWriteClient client = getHoodieWriteClient(cfgBuilder.build());
Review Comment:
> Get the client in try-with-resource block
This makes the client a final variable and re-init was not possible. Added
the close in a finally block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
