[
https://issues.apache.org/jira/browse/HUDI-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wangxianghu updated HUDI-1062:
------------------------------
Description:
{code:java}
//code
maxEventsToReadFromKafka = (maxEventsToReadFromKafka == Long.MAX_VALUE ||
maxEventsToReadFromKafka == Integer.MAX_VALUE)
? Config.maxEventsFromKafkaSource : maxEventsToReadFromKafka;
{code}
this line is unnecessary, we‘d better remove it.
besides, when the source limit is not configured, it will take
*maxEventsToReadFromKafka*(50M) as the default value, we can give a log to
notify the user.
was:
{code:java}
//代码占位符
maxEventsToReadFromKafka = (maxEventsToReadFromKafka == Long.MAX_VALUE ||
maxEventsToReadFromKafka == Integer.MAX_VALUE)
? Config.maxEventsFromKafkaSource : maxEventsToReadFromKafka;
{code}
this two line is
> Remove unnecessary maxEvent check in KafkaOffsetGen
> ---------------------------------------------------
>
> Key: HUDI-1062
> URL: https://issues.apache.org/jira/browse/HUDI-1062
> Project: Apache Hudi
> Issue Type: Task
> Components: Code Cleanup
> Reporter: wangxianghu
> Assignee: Trevorzhang
> Priority: Minor
>
> {code:java}
> //code
> maxEventsToReadFromKafka = (maxEventsToReadFromKafka == Long.MAX_VALUE ||
> maxEventsToReadFromKafka == Integer.MAX_VALUE)
> ? Config.maxEventsFromKafkaSource : maxEventsToReadFromKafka;
> {code}
> this line is unnecessary, we‘d better remove it.
> besides, when the source limit is not configured, it will take
> *maxEventsToReadFromKafka*(50M) as the default value, we can give a log to
> notify the user.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
