amrishlal commented on code in PR #9336:
URL: https://github.com/apache/hudi/pull/9336#discussion_r1281234205
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -203,6 +204,12 @@ public HoodieDefaultTimeline findInstantsInRange(String
startTs, String endTs) {
getInstantsAsStream().filter(s ->
HoodieTimeline.isInRange(s.getTimestamp(), startTs, endTs)), details);
}
+ @Override
+ public HoodieDefaultTimeline findInstantsInClosedRange(String startTs,
String endTs) {
Review Comment:
I don't see this function being called from anywhere? Also, wondering if
this time interval can be made half open? There are advantages in having time
intervals as half open instead of closed as described
[here](https://wrschneider.github.io/2014/01/07/time-intervals-and-other-ranges-should.html)
and
[here](https://stackoverflow.com/questions/9795391/is-there-a-standard-for-inclusive-exclusive-ends-of-time-intervals).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
