baobaoyeye commented on a change in pull request #1739:
URL: https://github.com/apache/hudi/pull/1739#discussion_r447956502
##########
File path:
hudi-client/src/test/java/org/apache/hudi/client/TestHoodieClientOnCopyOnWriteStorage.java
##########
@@ -849,7 +848,7 @@ public void testCommitWritesRelativePaths() throws
Exception {
}
/**
- * Test to ensure commit metadata points to valid files.
+ * Test to ensure commit metadata points to valid files.10.
*/
@Test
public void testRollingStatsInMetadata() throws Exception {
Review comment:
fixed
##########
File path:
hudi-client/src/test/java/org/apache/hudi/table/TestHoodieMergeOnReadTable.java
##########
@@ -1094,14 +1093,10 @@ public void testRollingStatsInMetadata() throws
Exception {
HoodieCommitMetadata metadata = HoodieCommitMetadata.fromBytes(
table.getActiveTimeline().getInstantDetails(table.getActiveTimeline().getDeltaCommitTimeline().lastInstant().get()).get(),
HoodieCommitMetadata.class);
- HoodieRollingStatMetadata rollingStatMetadata =
HoodieCommitMetadata.fromBytes(
-
metadata.getExtraMetadata().get(HoodieRollingStatMetadata.ROLLING_STAT_METADATA_KEY).getBytes(),
- HoodieRollingStatMetadata.class);
int inserts = 0;
- for (Map.Entry<String, Map<String, HoodieRollingStat>> pstat :
rollingStatMetadata.getPartitionToRollingStats()
- .entrySet()) {
- for (Map.Entry<String, HoodieRollingStat> stat :
pstat.getValue().entrySet()) {
- inserts += stat.getValue().getInserts();
+ for (Map.Entry<String, List<HoodieWriteStat>> pstat :
metadata.getPartitionToWriteStats().entrySet()) {
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
