the-other-tim-brown commented on code in PR #9337:
URL: https://github.com/apache/hudi/pull/9337#discussion_r1283384777
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -481,10 +482,10 @@ private Pair<Integer, HoodieData<HoodieRecord>>
initializeRecordIndexPartition()
// Collect the list of latest base files present in each partition
List<String> partitions = metadata.getAllPartitionPaths();
fsView.loadAllPartitions();
- final List<Pair<String, String>> partitionBaseFilePairs = new
ArrayList<>();
+ final List<Pair<String, HoodieBaseFile>> partitionBaseFilePairs = new
ArrayList<>();
Review Comment:
Ok I'm a bit confused here. The HoodieBaseFile is and always was created at
line 487 below so we are creating the object regardless. When we create a list
with these objects, we will store a reference to the object and not make a copy
of the object, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
