amrishlal commented on code in PR #9324:
URL: https://github.com/apache/hudi/pull/9324#discussion_r1283598675
##########
pom.xml:
##########
@@ -98,8 +98,6 @@
<fasterxml.jackson.databind.version>${fasterxml.spark3.version}</fasterxml.jackson.databind.version>
<fasterxml.jackson.module.scala.version>${fasterxml.spark3.version}</fasterxml.jackson.module.scala.version>
<fasterxml.jackson.dataformat.yaml.version>${fasterxml.spark3.version}</fasterxml.jackson.dataformat.yaml.version>
- <!-- NOTE: By default we're not including JSR310 module for Jackson since
Spark >= 3.x is bundling it anyway -->
- <fasterxml.jackson.datatype.jsr310.module/>
Review Comment:
@danny0405 For now, we seem to be shading all the jackson packages and hence
it seems like a good idea to shade jackson JSR package as well to keep the
versions across jackson packages consistent (otherwise testing may become
problematic). But yes, as a future item we could look into not shading any of
the jackson packages at all for spark versions (>= 3.1 I think) where Jackson
is already being included. We would also need to confirm on the Flink side (as
I was seeing some errors in Flink validate bundles tests). For now though we
would like to get our integration test setup up and running as that is blocked
by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
