lokeshj1703 commented on code in PR #9345:
URL: https://github.com/apache/hudi/pull/9345#discussion_r1284806150
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestColumnStatsIndex.scala:
##########
Review Comment:
Done
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/MergeOnReadIncrementalRelation.scala:
##########
@@ -108,7 +110,9 @@ case class MergeOnReadIncrementalRelation(override val
sqlContext: SQLContext,
}.toSeq
}
- buildSplits(filterFileSlices(fileSlices, globPattern))
+ var filteredFileSlices = filterFileSlices(fileSlices, globPattern)
Review Comment:
After reverting my changes the test is failing for the case when full table
scan is enabled with incremental query.
`DataSourceReadOptions.INCREMENTAL_FALLBACK_TO_FULL_TABLE_SCAN_FOR_NON_EXISTING_FILES.key
-> "true"`
So I have still kept the changes. We can think about it and revert if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
