vinothchandar commented on code in PR #9367:
URL: https://github.com/apache/hudi/pull/9367#discussion_r1285149102
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -440,6 +447,10 @@ public int getRecordIndexMaxParallelism() {
return getInt(RECORD_INDEX_MAX_PARALLELISM);
}
+ public boolean isFileSystemBootstrapDisabled() {
Review Comment:
to be renamed along with config name change.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -616,6 +616,9 @@ private HoodieTableMetaClient initializeMetaClient() throws
IOException {
* @return List consisting of {@code DirectoryInfo} for each partition found.
*/
private List<DirectoryInfo> listAllPartitionsFromFilesystem(String
initializationTime) {
+ if (dataWriteConfig.getMetadataConfig().isFileSystemBootstrapDisabled()) {
Review Comment:
food for thought : I think this should prevent any MDT partitions from being
initialized, not just `files`
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java:
##########
@@ -312,6 +312,13 @@ public final class HoodieMetadataConfig extends
HoodieConfig {
.withDocumentation("Maximum size in bytes of a single log file. Larger
log files can contain larger log blocks "
+ "thereby reducing the number of blocks to search for keys");
+ public static final ConfigProperty<Boolean> DISABLE_FILESYSTEM_BOOTSTRAP =
ConfigProperty
+ .key(METADATA_PREFIX + ".filesystem.bootstrap.disabled")
+ .defaultValue(false)
+ .sinceVersion("0.14.0")
+ .withDocumentation("Disable bootstrapping metadata table from the file
system when the table is first created. "
Review Comment:
We can mark this advanced. (@yihua to confirm) .
On naming : just `hoodie.metadata.bootstrap.disabled` or
`hoodie.metadata.auto.initialize` = true (default)| false?
Thats the best I can think of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
