nsivabalan commented on code in PR #9382:
URL: https://github.com/apache/hudi/pull/9382#discussion_r1286040968
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -172,9 +172,6 @@ case class MergeIntoHoodieTableCommand(mergeInto:
MergeIntoTable) extends Hoodie
expressionSet.remove((attr, expr))
(attr, expr)
}
- if (resolving.isEmpty && rk._1.equals("primaryKey")) {
Review Comment:
what was the behavior in 0.13.0 ? I guess we did have some restrictions.
atleast we should go back to that state.
I mean, it should not be that, we are completely open on the join condition.
Even if someone does not specify any primary key col in join, do the MIT
succeed or fail ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
