yihua commented on code in PR #9377:
URL: https://github.com/apache/hudi/pull/9377#discussion_r1286574250
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/KafkaOffsetPostProcessor.java:
##########
@@ -43,7 +45,7 @@ public static class Config {
HoodieStreamerConfig.KAFKA_APPEND_OFFSETS;
public static boolean shouldAddOffsets(TypedProperties props) {
- return props.getBoolean(HoodieStreamerConfig.KAFKA_APPEND_OFFSETS.key(),
Boolean.parseBoolean(HoodieStreamerConfig.KAFKA_APPEND_OFFSETS.defaultValue()));
+ return getBooleanWithAltKeys(props,
HoodieStreamerConfig.KAFKA_APPEND_OFFSETS);
Review Comment:
For `getBooleanWithAltKeys` it would be overkill. For String value, I added
different flavors of `getStringWithAltKeys`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
