wecharyu commented on code in PR #9408:
URL: https://github.com/apache/hudi/pull/9408#discussion_r1289521158
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/HoodieSqlCommonUtils.scala:
##########
@@ -330,23 +330,36 @@ object HoodieSqlCommonUtils extends SparkAdapterSupport {
val allPartitionPaths = hoodieCatalogTable.getPartitionPaths
val enableHiveStylePartitioning =
isHiveStyledPartitioning(allPartitionPaths, table)
val enableEncodeUrl = isUrlEncodeEnabled(allPartitionPaths, table)
- val partitionsToDrop = normalizedSpecs.map { spec =>
- hoodieCatalogTable.partitionFields.map { partitionColumn =>
- val encodedPartitionValue = if (enableEncodeUrl) {
- PartitionPathEncodeUtils.escapePathName(spec(partitionColumn))
- } else {
- spec(partitionColumn)
- }
- if (enableHiveStylePartitioning) {
- partitionColumn + "=" + encodedPartitionValue
- } else {
Review Comment:
Not remove it, just reuse the common implementation of `makePartitionPath`
which will handle hive style and url encode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
