yihua commented on code in PR #8111:
URL: https://github.com/apache/hudi/pull/8111#discussion_r1290679214
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/config/TestHoodieWriteConfig.java:
##########
@@ -140,8 +140,10 @@ public void
testAutoConcurrencyConfigAdjustmentWithTableServices(HoodieTableType
put(ASYNC_CLEAN.key(), "false");
put(HoodieWriteConfig.AUTO_ADJUST_LOCK_CONFIGS.key(), "true");
}
- }), true, true, true,
WriteConcurrencyMode.OPTIMISTIC_CONCURRENCY_CONTROL,
- HoodieFailedWritesCleaningPolicy.LAZY, inProcessLockProviderClassName);
+ }), true, true, true,
Review Comment:
We should revert the changes in this PR to a degree that the auto-adjustment
of the lock configs still works for single-writer with async table services.
Right now, auto-adjustment of the lock configs does not work for Deltastreamer
with async table services when the metadata table is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
