danny0405 commented on code in PR #8111:
URL: https://github.com/apache/hudi/pull/8111#discussion_r1290818989
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/config/TestHoodieWriteConfig.java:
##########
@@ -140,8 +140,10 @@ public void
testAutoConcurrencyConfigAdjustmentWithTableServices(HoodieTableType
put(ASYNC_CLEAN.key(), "false");
put(HoodieWriteConfig.AUTO_ADJUST_LOCK_CONFIGS.key(), "true");
}
- }), true, true, true,
WriteConcurrencyMode.OPTIMISTIC_CONCURRENCY_CONTROL,
- HoodieFailedWritesCleaningPolicy.LAZY, inProcessLockProviderClassName);
+ }), true, true, true,
Review Comment:
If metadata table is enabled, the lock should take effect, because the
default lock provider class is `ZookeeperBasedLockProvider`, so at least, the
in-progress lock should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
