danny0405 commented on code in PR #9413:
URL: https://github.com/apache/hudi/pull/9413#discussion_r1290848015
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -147,7 +148,9 @@ List<HoodieCleanStat> clean(HoodieEngineContext context,
HoodieCleanerPlan clean
List<String> partitionsToBeDeleted =
cleanerPlan.getPartitionsToBeDeleted() != null ?
cleanerPlan.getPartitionsToBeDeleted() : new ArrayList<>();
partitionsToBeDeleted.forEach(entry -> {
try {
- deleteFileAndGetResult(table.getMetaClient().getFs(),
table.getMetaClient().getBasePath() + "/" + entry);
+ if (!StringUtils.isNullOrEmpty(entry)) {
+ deleteFileAndGetResult(table.getMetaClient().getFs(),
table.getMetaClient().getBasePath() + "/" + entry);
Review Comment:
Kind of think the `cleanerPlan.getPartitionsToBeDeleted()` should be fixed,
can we write a test case for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
