amrishlal commented on code in PR #9433:
URL: https://github.com/apache/hudi/pull/9433#discussion_r1291826591
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/IncrSourceHelper.java:
##########
@@ -219,7 +218,7 @@ public static Pair<CloudObjectIncrCheckpoint, Dataset<Row>>
filterAndGenerateChe
}
LOG.info("Processed batch size: " +
row.get(row.fieldIndex(CUMULATIVE_COLUMN_NAME)) + " bytes");
sourceData.unpersist();
- return Pair.of(new CloudObjectIncrCheckpoint(row.getString(0),
row.getString(1)), collectedRows);
+ return Pair.of(new CloudObjectIncrCheckpoint(row.getString(0),
row.getString(1)), Option.of(collectedRows));
Review Comment:
Minor: Would suggest using row.fieldIndex just like what you have for
`CUMULATIVE_COLUMN_NAME1`
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/IncrSourceHelper.java:
##########
@@ -219,7 +218,7 @@ public static Pair<CloudObjectIncrCheckpoint, Dataset<Row>>
filterAndGenerateChe
}
LOG.info("Processed batch size: " +
row.get(row.fieldIndex(CUMULATIVE_COLUMN_NAME)) + " bytes");
sourceData.unpersist();
- return Pair.of(new CloudObjectIncrCheckpoint(row.getString(0),
row.getString(1)), collectedRows);
+ return Pair.of(new CloudObjectIncrCheckpoint(row.getString(0),
row.getString(1)), Option.of(collectedRows));
Review Comment:
Also, please open a ticket for optimizations that we were discussing offline
(Use of `applyOrdering` in line 182 and `commit_key` temporary column)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
