yihua commented on code in PR #8944:
URL: https://github.com/apache/hudi/pull/8944#discussion_r1294988920
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java:
##########
@@ -263,8 +263,7 @@ private int doCompact(JavaSparkContext jsc) throws
Exception {
if (StringUtils.isNullOrEmpty(cfg.compactionInstantTime)) {
HoodieTableMetaClient metaClient = UtilHelpers.createMetaClient(jsc,
cfg.basePath, true);
Option<HoodieInstant> firstCompactionInstant =
- metaClient.getActiveTimeline().firstInstant(
- HoodieTimeline.COMPACTION_ACTION,
HoodieInstant.State.REQUESTED);
+
metaClient.getActiveTimeline().filterPendingCompactionTimeline().firstInstant();
Review Comment:
Same for compaction, this should be safe:
```
protected HoodieWriteMetadata<O> compact(String compactionInstantTime,
boolean shouldComplete) {
HoodieTable<?, I, ?, T> table = createTable(config,
context.getHadoopConf().get());
HoodieTimeline pendingCompactionTimeline =
table.getActiveTimeline().filterPendingCompactionTimeline();
HoodieInstant inflightInstant =
HoodieTimeline.getCompactionInflightInstant(compactionInstantTime);
if (pendingCompactionTimeline.containsInstant(inflightInstant)) {
table.rollbackInflightCompaction(inflightInstant, commitToRollback ->
getPendingRollbackInfo(table.getMetaClient(), commitToRollback, false));
table.getMetaClient().reloadActiveTimeline();
}
compactionTimer = metrics.getCompactionCtx();
HoodieWriteMetadata<T> writeMetadata = table.compact(context,
compactionInstantTime);
HoodieWriteMetadata<O> compactionMetadata =
convertToOutputMetadata(writeMetadata);
if (shouldComplete &&
compactionMetadata.getCommitMetadata().isPresent()) {
completeCompaction(compactionMetadata.getCommitMetadata().get(),
table, compactionInstantTime);
}
return compactionMetadata;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
