rmahindra123 commented on code in PR #9455:
URL: https://github.com/apache/hudi/pull/9455#discussion_r1298093168
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroHFileReader.java:
##########
@@ -204,7 +212,9 @@ protected ClosableIterator<IndexedRecord>
getIndexedRecordIterator(Schema reader
} catch (IOException e) {
throw new HoodieIOException("Instantiation HfileScanner failed for " +
reader.getHFileInfo().toString());
}
- return new RecordIterator(scanner, getSchema(), readerSchema);
+ RecordIterator iterator = new RecordIterator(scanner, getSchema(),
readerSchema);
+ recordIterators.add(iterator);
Review Comment:
Yeah this was just to test the leaks. We will raise PR with better coding
practice in a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]