nsivabalan commented on code in PR #9468:
URL: https://github.com/apache/hudi/pull/9468#discussion_r1298610736
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -223,6 +223,10 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K,
O> table, HoodieInstan
);
if (!skipLocking) {
this.txnManager.beginTransaction(Option.of(inflightInstant),
Option.empty());
+ table.getMetaClient().reloadActiveTimeline();
Review Comment:
already we do reload the timeline at L218. So, do we still need this reload?
if we are concerned about TOCTOU, even there could be a gap here right. just
after L 228, the clean could have been completed by another concurrent writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
