the-other-tim-brown commented on code in PR #9488:
URL: https://github.com/apache/hudi/pull/9488#discussion_r1299540031
##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/BigQuerySyncConfig.java:
##########
@@ -128,6 +128,12 @@ public class BigQuerySyncConfig extends HoodieSyncConfig
implements Serializable
.withDocumentation("Assume standard yyyy/mm/dd partitioning, this"
+ " exists to support backward compatibility. If you use hoodie
0.3.x, do not set this parameter");
+ public static final ConfigProperty<Boolean>
BIGQUERY_SYNC_ALLOW_READ_OPTIMIZED_SYNC = ConfigProperty
+ .key("hoodie.gcp.bigquery.sync.allow_read_optimized_sync")
+ .defaultValue(false)
Review Comment:
The main reason why I didn't have it enabled by default was since this is
explicitly not allowed in the code today so I wanted to be on the safe side. I
don't think there is any plan for Google Cloud to support snapshot query, have
you heard otherwise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
