harsh1231 commented on code in PR #9545: URL: https://github.com/apache/hudi/pull/9545#discussion_r1307247611
########## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java: ########## @@ -129,6 +129,9 @@ public class HoodieAppendHandle<T, I, K, O> extends HoodieWriteHandle<T, I, K, O private boolean useWriterSchema = false; private Properties recordProperties = new Properties(); + // Block Sequence number will be used to detect duplicate log blocks(by log reader) added due to spark task retries. + // It should always start with 0 for a given file slice. for roll overs and delete blocks, we increment by 1. + private int blockSequenceNumber = 0; Review Comment: Will this not get reinitialized when spark task is retried ? class is reinstantiated i think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
