Zouxxyy commented on code in PR #9554:
URL: https://github.com/apache/hudi/pull/9554#discussion_r1308145131
##########
hudi-spark-datasource/hudi-spark-common/pom.xml:
##########
@@ -228,6 +228,19 @@
<scope>test</scope>
</dependency>
+ <!-- Hive -->
+ <dependency>
+ <groupId>${hive.groupid}</groupId>
+ <artifactId>hive-exec</artifactId>
+ <classifier>${hive.exec.classifier}</classifier>
+ <exclusions>
+ <exclusion>
Review Comment:
`hudi-hadoop-mr` is already dependent, and currently
`hudi-spark-datasource/hudi-spark` also depends on `hive-exec`
Of course, if we don't want to add `hive-exec` dependency in
`hudi-spark-datasource/hudi-common`, we can change it like this
```scala
val inputFormat = tableType match {
case DataSourceWriteOptions. COW_TABLE_TYPE_OPT_VAL =>
"org.apache.hudi.hadoop.HoodieParquetInputFormat"
case DataSourceWriteOptions.MOR_TABLE_TYPE_OPT_VAL =>
"org.apache.hudi.hadoop.realtime.HoodieParquetRealtimeInputFormat"
case _=> throw new IllegalArgumentException(s"UnKnow table
type:$tableType")
}
```
which way do you think is better~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
