KnightChess commented on PR #8610: URL: https://github.com/apache/hudi/pull/8610#issuecomment-1698503648
> > why not throw exception? > > Which step you mean to throw exception, we generally need some lock to make the instant time generation monotonically increasing. Currently we have no good manner to ensure that, but for HDFS, same name file creation would throws if the overwrite is disabled. yes, I think we need throw the exception, if multi job use then same instance to process, one of them should need to fail. And on the other hand, the atomicity of the method(createImmutableFileInPath) should be guaranteed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
