n3nash commented on pull request #1704: URL: https://github.com/apache/hudi/pull/1704#issuecomment-654623082
@bhasudha The PR looks good to me. Looks like the same ordering field will be honored in all places. One high level question before I accept it -> If `preCombine` & `combineAndGetUpdateValue` are using the same `orderingVal`, I'm guessing it is expected from the user to use the constructor with the `orderingVal` and up to the user to ensure the `orderingVal` used in the constructor is the same as the one passed in `Map<..>`. Can you put a comment around this please ? Also, please rebase and push the PR, once the build succeeds can merge it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
