xuzifu666 commented on PR #9601:
URL: https://github.com/apache/hudi/pull/9601#issuecomment-1702763384

   > What's the ambiguity here? Does it behave differently for scala 2.11, 2.12 
and 2.13? `HoodieWriteConfig.newBuilder.withProps()` accepts a Map. Before 
putAll, if we just do `JavaConverters.mapAsJavaMapConverter(hudiOpts).asJava`, 
it should be sufficient right? Why do we have to wrap in 
`TypedProperties.fromMap`?
   
   @codope it is a bug in scala2.12 https://github.com/scala/bug/issues/10418 
,when we run some ut would report error like: ambiguous reference to overloaded 
definition,
   both method putAll in class Properties of type (x$1: java.util.Map[_, _])Unit
   and  method putAll in class Hashtable of type (x$1: java.util.Map[_ <: 
Object, _ <: Object])Unit
   match argument types (java.util.Map[String,String])
       props.putAll(hudiOpts.asJava).                        we also fix it in 
moulde https://github.com/apache/hudi/pull/8511


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to