codope commented on code in PR #9611:
URL: https://github.com/apache/hudi/pull/9611#discussion_r1314102379
##########
pom.xml:
##########
@@ -176,7 +176,7 @@
<scala12.version>2.12.10</scala12.version>
<scala.version>${scala12.version}</scala.version>
<scala.collection-compat.version>2.8.1</scala.collection-compat.version>
- <scala.binary.version>2.12</scala.binary.version>
+ <scala.binary.version>2.11</scala.binary.version>
Review Comment:
undo?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -461,11 +464,11 @@ protected void
appendDataAndDeleteBlocks(Map<HeaderMetadataType, String> header,
? HoodieRecord.RECORD_KEY_METADATA_FIELD
:
hoodieTable.getMetaClient().getTableConfig().getRecordKeyFieldProp();
- blocks.add(getBlock(config, pickLogDataBlockFormat(), recordList,
getUpdatedHeader(header, blockSequenceNumber++,
taskContextSupplier.getAttemptIdSupplier().get()), keyField));
+ blocks.add(getBlock(config, pickLogDataBlockFormat(), recordList,
getUpdatedHeader(header, blockSequenceNumber++, attemmptNo), keyField));
Review Comment:
I guess incrementing `attemptNo` is taken care of by the engone context
itself?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -429,30 +429,44 @@ private Pair<Boolean, List<HoodieLogBlock>>
reconcileSpuriousBlocksAndGetValidOn
boolean dupsFound =
blockSequenceMapPerCommit.values().stream().anyMatch(perCommitBlockList ->
perCommitBlockList.size() > 1);
if (dupsFound) {
+ if (LOG.isDebugEnabled()) {
+ LOG.warn("Duplicate log blocks found ");
Review Comment:
this log can be moved out
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/LocalTaskContextSupplier.java:
##########
@@ -45,4 +45,10 @@ public Supplier<Long> getAttemptIdSupplier() {
public Option<String> getProperty(EngineProperty prop) {
return Option.empty();
}
+
+ @Override
+ public Supplier<Integer> getAttemptNoSupplier() {
Review Comment:
let's rename to `getAttemptNumberSupplier` instead of abbv for no.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
