nsivabalan commented on code in PR #9546:
URL: https://github.com/apache/hudi/pull/9546#discussion_r1317735174
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -1003,12 +1003,8 @@ private boolean shouldExecuteMetadataTableDeletion() {
// Only execute metadata table deletion when all the following conditions
are met
// (1) This is data table
// (2) Metadata table is disabled in HoodieWriteConfig for the writer
- // (3) Check `HoodieTableConfig.TABLE_METADATA_PARTITIONS`. Either the
table config
- // does not exist, or the table config is non-empty indicating that
metadata table
- // partitions are ready to use
return !HoodieTableMetadata.isMetadataTable(metaClient.getBasePath())
- && !config.isMetadataTableEnabled()
- && !metaClient.getTableConfig().getMetadataPartitions().isEmpty();
Review Comment:
yeah. When we upstreamed patches from uber, we had an idea that we will not
allow disabling metadata table via write configs only. Once enabled, user has
to go via hudi-cli to disable it.
but due to operational overhead, we are reverting this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
