nsivabalan commented on code in PR #9611:
URL: https://github.com/apache/hudi/pull/9611#discussion_r1317986246
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/client/FlinkTaskContextSupplier.java:
##########
@@ -62,4 +62,9 @@ public Option<String> getProperty(EngineProperty prop) {
return Option.empty();
}
+ @Override
+ public Supplier<Integer> getAttemptNumberSupplier() {
+ return () -> -1;
Review Comment:
as of now, I have disabled it for flink. can you test it out and fix it.
here is the situation w/ spark.
Lets say we want to spin up 10 tasks for a stage.
in first attempt,
each task will be assigned numbers from 1 to 10 for attemptId. but for
attempNumber, it will be 0.
and when a subset of tasks are retried, new attemptIds will be 11, 12 etc.
but attemptNumber will be 1.
This is how it works in spark. I am not very sure on flink. Anyways, w/
latest commit, we are avoiding writing the block identifier flink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
