danny0405 commented on code in PR #9650:
URL: https://github.com/apache/hudi/pull/9650#discussion_r1319245196


##########
hudi-gcp/src/main/java/org/apache/hudi/gcp/bigquery/HoodieBigQuerySyncClient.java:
##########
@@ -94,8 +94,9 @@ public void createTableUsingBqManifestFile(String tableName, 
String bqManifestFi
       }
       String query =
           String.format(
-              "CREATE EXTERNAL TABLE `%s.%s` %s OPTIONS (%s "
+              "CREATE EXTERNAL TABLE `%s.%s.%s` %s OPTIONS (%s "
               + "uris=[\"%s\"], format=\"PARQUET\", 
file_set_spec_type=\"NEW_LINE_DELIMITED_MANIFEST\")",
+              projectId,

Review Comment:
   Nice catch ~ Is the projectId always required for BigQuery sync?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to