nsivabalan commented on code in PR #9473:
URL: https://github.com/apache/hudi/pull/9473#discussion_r1321070806
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/IncrSourceHelper.java:
##########
@@ -130,7 +130,7 @@ public static QueryInfo generateQueryInfo(JavaSparkContext
jssc, String srcBaseP
}
});
- String previousInstantTime = beginInstantTime;
+ String previousInstantTime = DEFAULT_BEGIN_TIMESTAMP;
if (!beginInstantTime.equals(DEFAULT_BEGIN_TIMESTAMP)) {
Option<HoodieInstant> previousInstant =
activeCommitTimeline.findInstantBefore(beginInstantTime);
if (previousInstant.isPresent()) {
Review Comment:
synced up w/ lokesk J.guess this is what he is saying.
lets say active timeline is from C5 until C10.
when beginInstantTime is C5, as per this patch, previous will be set to
00000000000000. and down the line, when we trigger incremental query, we will
set previous i.e. 00000000000000) as the begin instant time which is not what
we want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
