stream2000 commented on code in PR #9651:
URL: https://github.com/apache/hudi/pull/9651#discussion_r1321266607
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -418,6 +418,12 @@ public class HoodieWriteConfig extends HoodieConfig {
.sinceVersion("0.9.0")
.withDocumentation(MarkerType.class);
+ public static final ConfigProperty<Boolean>
TIMELINE_SERVER_BASED_FLINK_CKP_METADATA = ConfigProperty
+ .key("hoodie.flink.ckp_metadata.timeline_server_based.enable")
+ .defaultValue(true)
Review Comment:
Thanks for your review~
> Can we remove the flink keywork here
Removing the `flink` keyword is OK.
> do we need an option for it, just add a new URI on the timeline server
should be fine.
I'm mainly following the implementation of timeline-based markers which have
an option for enabling timeline-based markers or not, too.
> you need to handle the diffferent request from various clients in good
manner.
The parameter of Ckp metadata Handler is the full ckp metadata path, which
already contains the uniqueId of one specific job. I think it's enough for the
multi-client scenario, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
