bhasudha commented on code in PR #9486: URL: https://github.com/apache/hudi/pull/9486#discussion_r1321566891
########## website/docs/key_generation.md: ########## @@ -20,43 +24,44 @@ generators that are readily available to use. [Here](https://github.com/apache/hudi/blob/6f9b02decb5bb2b83709b1b6ec04a97e4d102c11/hudi-common/src/main/java/org/apache/hudi/keygen/KeyGenerator.java) is the interface for KeyGenerator in Hudi for your reference. -Before diving into different types of key generators, let’s go over some of the common configs required to be set for -key generators. +Before diving into different types of key generators, let’s go over some of the common configs relevant to key generators. -| Config | Meaning/purpose| -| ------------- |:-------------:| -| ```hoodie.datasource.write.recordkey.field``` | Refers to record key field. This is a mandatory field. | -| ```hoodie.datasource.write.partitionpath.field``` | Refers to partition path field. This is a mandatory field. | -| ```hoodie.datasource.write.keygenerator.class``` | Refers to Key generator class(including full path). Could refer to any of the available ones or user defined one. This is a mandatory field. | -| ```hoodie.datasource.write.partitionpath.urlencode```| When set to true, partition path will be url encoded. Default value is false. | -| ```hoodie.datasource.write.hive_style_partitioning```| When set to true, uses hive style partitioning. Partition field name will be prefixed to the value. Format: “<partition_path_field_name>=<partition_path_value>”. Default value is false.| +| Config Name | Default | Description | +| ---------------------------------------------------------------------------------------- |------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| +| hoodie.datasource.write.recordkey.field | N/A (Optional) | Record key field. Value to be used as the `recordKey` component of `HoodieKey`. <ul><li>When configured, actual value will be obtained by invoking .toString() on the field value. Nested fields can be specified using the dot notation eg: `a.b.c`. </li><li>When not configured record key will be automatically generated by Hudi.</li></ul> <br />`Config Param: RECORDKEY_FIELD_NAME` | Review Comment: `When not configured record key will be automatically generated by Hudi.` is already there. I extended it to add `When not configured record key will be automatically generated by Hudi. This feature is handy for use cases like log ingestion that do not have a naturally present record key.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
