This is an automated email from the ASF dual-hosted git repository.
danny0405 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new 18dcceb6d61 [HUDI-6823] instantiate writeTimer in
StreamWriteOperatorCoordinator (#9637)
18dcceb6d61 is described below
commit 18dcceb6d619e2899fc133e8bb7204b3f8302792
Author: leixin <[email protected]>
AuthorDate: Wed Sep 13 12:33:55 2023 +0800
[HUDI-6823] instantiate writeTimer in StreamWriteOperatorCoordinator (#9637)
---
.../src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java | 5 ++---
.../java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java | 1 +
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
index 7a68fd2aca5..3938a490c47 100644
---
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
+++
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
@@ -1308,7 +1308,7 @@ public abstract class BaseHoodieWriteClient<T, I, K, O>
extends BaseHoodieClient
case BULK_INSERT_PREPPED:
case INSERT_OVERWRITE:
case INSERT_OVERWRITE_TABLE:
- setWriteTimer(table);
+ setWriteTimer(table.getMetaClient().getCommitActionType());
break;
case CLUSTER:
case COMPACT:
@@ -1365,8 +1365,7 @@ public abstract class BaseHoodieWriteClient<T, I, K, O>
extends BaseHoodieClient
this.tableServiceClient.close();
}
- private void setWriteTimer(HoodieTable table) {
- String commitType = table.getMetaClient().getCommitActionType();
+ public void setWriteTimer(String commitType) {
if (commitType.equals(HoodieTimeline.COMMIT_ACTION)) {
writeTimer = metrics.getCommitCtx();
} else if (commitType.equals(HoodieTimeline.DELTA_COMMIT_ACTION)) {
diff --git
a/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java
b/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java
index dd9b7e9141e..34d8322dd9d 100644
---
a/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java
+++
b/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java
@@ -390,6 +390,7 @@ public class StreamWriteOperatorCoordinator
// because the instant request from write task is asynchronous.
this.instant = this.writeClient.startCommit(tableState.commitAction,
this.metaClient);
this.metaClient.getActiveTimeline().transitionRequestedToInflight(tableState.commitAction,
this.instant);
+ this.writeClient.setWriteTimer(tableState.commitAction);
this.ckpMetadata.startInstant(this.instant);
LOG.info("Create instant [{}] for table [{}] with type [{}]", this.instant,
this.conf.getString(FlinkOptions.TABLE_NAME),
conf.getString(FlinkOptions.TABLE_TYPE));