stream2000 commented on code in PR #9651:
URL: https://github.com/apache/hudi/pull/9651#discussion_r1325313091
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java:
##########
@@ -20,14 +20,22 @@
import org.apache.hudi.common.fs.FSUtils;
import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.timeline.dto.CkpMetadataDTO;
Review Comment:
> Can we extend a sub-class instead of messing up the existing logic then?
Yes sure, already moved to a sub class. And I have refactor the constructors
of `CkpMetadata`, now we have only one entry for creating ckpmetadata.
> And do we have some fallback logic when the HTTP request timed out or
throws ?
Yes, when requesting timeline server failed we will read from file system
directly. Added tests about this.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -418,6 +418,12 @@ public class HoodieWriteConfig extends HoodieConfig {
.sinceVersion("0.9.0")
.withDocumentation(MarkerType.class);
+ public static final ConfigProperty<Boolean>
TIMELINE_SERVER_BASED_FLINK_CKP_METADATA = ConfigProperty
+ .key("hoodie.flink.ckp_metadata.timeline_server_based.enable")
+ .defaultValue(true)
Review Comment:
> hoodie.ckp_metadata.timeline_server_based.enable ->
hoodie.instant_state.timeline_server_based.enabled
done
##########
hudi-timeline-service/src/main/java/org/apache/hudi/timeline/service/RequestHandler.java:
##########
@@ -505,6 +516,24 @@ private void registerMarkerAPI() {
}, false));
}
+ private void registerFlinkCkpMetadataAPI() {
+ app.get(FlinkCkpMetadataHandler.ALL_CKP_METADATA_URL, new ViewHandler(ctx
-> {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
