codope commented on code in PR #9590:
URL: https://github.com/apache/hudi/pull/9590#discussion_r1325808124
##########
hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/cli/BootstrapExecutorUtils.java:
##########
@@ -269,6 +270,8 @@ private Pair<String, String>
genKeyGenClassAndPartitionColumns() {
keyGenClass =
props.getString(HoodieWriteConfig.KEYGENERATOR_CLASS_NAME.key());
} else if
(StringUtils.nonEmpty(props.getString(HoodieWriteConfig.KEYGENERATOR_TYPE.key(),
null))) {
keyGenClass =
HoodieSparkKeyGeneratorFactory.getKeyGeneratorClassName(props);
+ } else if
(StringUtils.nonEmpty(props.getString(HoodieTableConfig.KEY_GENERATOR_TYPE.key(),
null))) {
+ keyGenClass =
KeyGeneratorType.valueOf(props.getString(HoodieTableConfig.KEY_GENERATOR_TYPE.key())).getClassName();
Review Comment:
For this one I left the existing if-else blocks because one of them uses
`HoodieSparkKeyGeneratorFactory` which used some infer keygen function. I did
not want to change that order here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
