danny0405 commented on code in PR #9651:
URL: https://github.com/apache/hudi/pull/9651#discussion_r1329645320


##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/sink/utils/TestWriteBase.java:
##########
@@ -137,14 +140,17 @@ public static TestHarness instance() {
     private String lastPending;
     private String lastComplete;
 
+    private HoodieFlinkWriteClient writeClient;
+
     public TestHarness preparePipeline(File basePath, Configuration conf) 
throws Exception {
       this.baseFile = basePath;
       this.basePath = this.baseFile.getAbsolutePath();
       this.conf = conf;
       this.pipeline = TestData.getWritePipeline(this.basePath, conf);
       // open the function and ingest data
       this.pipeline.openFunction();
-      this.ckpMetadata = CkpMetadata.getInstance(conf);
+      this.writeClient = FlinkWriteClients.createWriteClient(conf);
+      this.ckpMetadata = 
CkpMetadataFactory.getCkpMetadata(StreamerUtil.createMetaClient(conf), 
writeClient.getConfig(), conf);

Review Comment:
   Not sure what is the purpose of the write config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to