boneanxs commented on code in PR #9617:
URL: https://github.com/apache/hudi/pull/9617#discussion_r1332391016
##########
hudi-platform-service/hudi-metaserver/hudi-metaserver-client/src/main/java/org/apache/hudi/common/table/timeline/HoodieMetaserverBasedTimeline.java:
##########
@@ -82,4 +88,18 @@ protected Option<byte[]> readDataFromPath(Path detailPath) {
public HoodieMetaserverBasedTimeline reload() {
return new HoodieMetaserverBasedTimeline(metaClient,
metaClient.getMetaserverConfig());
}
+
+ /**
+ * Completion time is essential for {@link HoodieActiveTimeline}, but for
MetaserverBasedTimeline,
+ * don't need completion time.
+ */
+ @Override
+ protected String getInstantFileName(HoodieInstant instant) {
+ if (instant.isCompleted()) {
+ // Set a fake completion time.
+ return instant.getFileName("0").replace("_0", "");
+ }
Review Comment:
Added [HUDI-6883](https://issues.apache.org/jira/browse/HUDI-6883) to track
this follow-up. To add completion time for `HoodieMetaserverBasedTimeline`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
