yihua commented on code in PR #9756:
URL: https://github.com/apache/hudi/pull/9756#discussion_r1334602602
##########
hudi-utils/src/main/java/org/apache/hudi/utils/HoodieConfigDocGenerator.java:
##########
@@ -188,15 +187,15 @@ private static ConfigTableRow
generateConfigTableRow(Class subType, Field field,
// Default value
Object defaultValue = cfgProperty.hasDefaultValue() ?
cfgProperty.defaultValue() : (cfgProperty.hasInferFunction() ? "" : null);
if (defaultValue != null) {
- columns.add(defaultValue + " (Optional)");
+ columns.add(defaultValue + " ");
} else {
- columns.add("N/A " + new BoldText("(Required)"));
+ columns.add(" ");
Review Comment:
Should we still keep `(N/A)` for no default value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
