xushiyan commented on a change in pull request #1819:
URL: https://github.com/apache/hudi/pull/1819#discussion_r453221663
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -67,7 +74,8 @@ public OverwriteWithLatestAvroPayload
preCombine(OverwriteWithLatestAvroPayload
GenericRecord genericRecord = (GenericRecord) recordOption.get();
// combining strategy here trivially ignores currentValue on disk and
writes this record
- Object deleteMarker = genericRecord.get("_hoodie_is_deleted");
+ String deleteField = userDefineDeleteField == null ? DEFAULT_DELETE_FIELD
: userDefineDeleteField;
+ Object deleteMarker = genericRecord.get(deleteField);
Review comment:
The only caller to this method is
`org.apache.hudi.io.HoodieMergeHandle#write`, where you have access to
`HoodieWriteConfig config`.
If you make the configuration `delete.field` accessible from
`HoodieWriteConfig` then make this method
```java
public Option<IndexedRecord> combineAndGetUpdateValue(IndexedRecord
currentValue, Schema schema, Option<String> deleteField) {
}
```
then the overall logic will be simplified a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
