yihua commented on code in PR #7765:
URL: https://github.com/apache/hudi/pull/7765#discussion_r1335235764
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1896,6 +1897,26 @@ public Option<HoodieLogBlock.HoodieLogBlockType>
getLogDataBlockFormat() {
.map(HoodieLogBlock.HoodieLogBlockType::fromId);
}
+ public HoodieLogBlock.HoodieLogBlockType
pickLogDataBlockFormat(HoodieFileFormat format) {
Review Comment:
nit: rename the argument from `format` to `baseFileFormat`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1896,6 +1897,26 @@ public Option<HoodieLogBlock.HoodieLogBlockType>
getLogDataBlockFormat() {
.map(HoodieLogBlock.HoodieLogBlockType::fromId);
}
+ public HoodieLogBlock.HoodieLogBlockType
pickLogDataBlockFormat(HoodieFileFormat format) {
+ Option<HoodieLogBlock.HoodieLogBlockType> logBlockTypeOpt =
getLogDataBlockFormat();
+ if (logBlockTypeOpt.isPresent()) {
+ return logBlockTypeOpt.get();
+ }
+
+ // Fallback to deduce data-block type based on the base file format
+ switch (format) {
+ case PARQUET:
+ return HoodieLogBlock.HoodieLogBlockType.PARQUET_DATA_BLOCK;
Review Comment:
This switches the default log format from Avro to Parquet. I'm okay with
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
